Showing 337 of 433 total issues
Method tnef_attachments
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def tnef_attachments(content)
attachments = []
Dir.mktmpdir do |dir|
IO.popen("tnef -K -C #{dir} 2> /dev/null", "wb") do |f|
f.write(content)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method is_oof?
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def self.is_oof?(message)
# Check for out-of-office
if MailHandler.get_header_string("X-POST-MessageClass", message) == "9; Autoresponder"
return true
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method event_description
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def event_description(event)
body_link = public_body_link_absolute(event.info_request.public_body)
user_link = request_user_link_absolute(event.info_request)
date = simple_date(event.created_at)
case event.event_type
Method redeliver
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def redeliver
message_ids = params[:url_title].split(',').map(&:strip)
previous_request = @incoming_message.info_request
destination_request = nil
Method wall
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def wall
long_cache
@display_user = set_display_user
@is_you = current_user_is_display_user
feed_results = Set.new
Method signup
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def signup
# Make the user and try to save it
@user_signup = User.new(user_params(:user_signup))
error = false
if @request_from_foreign_country && !verify_recaptcha
Method update
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update
@pretoken_redirect = PostRedirect.find_by(token: @pretoken) if @pretoken
if @password_change_user
@password_change_user.password = params[:password_change_user][:password]
Method remove_quoted_sections
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.remove_quoted_sections(text, replacement = "FOLDED_QUOTED_SECTION")
text = text.dup
replacement = "\n" + replacement + "\n"
# First do this peculiar form of quoting, as the > single line quoting
Method alert_not_clarified_request
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.alert_not_clarified_request
info_requests = InfoRequest.
where("awaiting_description = ?
AND described_state = 'waiting_clarification'
AND info_requests.updated_at < ?
Method assign_variables_for_show_template
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
def assign_variables_for_show_template(info_request)
@info_request = info_request
@status = info_request.calculate_status
@old_unclassified =
info_request.is_old_unclassified? && authenticated?
Method hide
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
def hide
ActiveRecord::Base.transaction do
subject = params[:subject]
explanation = params[:explanation]
Method stop_new_responses_on_old_requests
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.stop_new_responses_on_old_requests
# 'old' months since last change to request, only allow new incoming
# messages from authority domains
InfoRequest.
been_published.
Method alert_new_response_reminders_internal
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.alert_new_response_reminders_internal(days_since, type_code)
info_requests = InfoRequest.
where_old_unclassified(days_since).
where(use_notifications: false).
order(:id).
Method show
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def show
medium_cache
AlaveteliLocalization.with_locale(locale) do
# Test for whole request being hidden
return render_hidden if cannot?(:read, @info_request)
Method create_request
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def create_request
json = ActiveSupport::JSON.decode(params[:request_json])
request = InfoRequest.new(
title: json["title"],
public_body_id: @public_body.id,
Method other_country_message
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def other_country_message
flash.keep
text = ""
site_country_code = AlaveteliConfiguration.iso_country_code.downcase
Method calculate_last_event_forming_initial_request
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def calculate_last_event_forming_initial_request
# TODO: This can be removed when last_event_forming_initial_request_id has
# been populated for all requests
expecting_clarification = false
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method convert_image
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def convert_image
return if data.nil?
return if image.nil?
# convert to PNG if it isn't, and to right size
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def update
if @user.suspended?
flash[:error] = _('Suspended users cannot edit their profile')
redirect_to edit_profile_about_me_path
return
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method single_xapian_value
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def single_xapian_value(field, type = nil)
value = send(field.to_sym) || self[field]
if type == :date
if value.is_a?(Time)
value.utc.strftime("%Y%m%d")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"