Sign upLogin

nabbar/SwaggerValidator-PHP

View on GitHub
Star
src/Compat.php

Summary

Maintainability
A
2 hrs
Test Coverage

apache_request_headers accesses the super-global variable $_SERVER.
Open

    function apache_request_headers()
    {
        $arh = array();

        foreach ($_SERVER as $key => $val) {
Severity: Minor
Found in src/Compat.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method random_int has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function random_int($min, $max)
    {
        if (!is_int($min) || !is_int($max)) {
            trigger_error('$min and $max must be integer values', E_USER_NOTICE);
            $min = (int) $min;
Severity: Minor
Found in src/Compat.php - About 1 hr to fix

    Function random_int has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        function random_int($min, $max)
    {
        if (!is_int($min) || !is_int($max)) {
            trigger_error('$min and $max must be integer values', E_USER_NOTICE);
            $min = (int) $min;
    Severity: Minor
    Found in src/Compat.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function apache_request_headers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        function apache_request_headers()
    {
        $arh = array();

        foreach ($_SERVER as $key => $val) {
    Severity: Minor
    Found in src/Compat.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused local variables such as '$counter'.
    Open

            $range   = $counter = $max - $min;
    Severity: Minor
    Found in src/Compat.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    The variable $arh_key is not named in camelCase.
    Open

        function apache_request_headers()
    {
        $arh = array();

        foreach ($_SERVER as $key => $val) {
    Severity: Minor
    Found in src/Compat.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $arh_key is not named in camelCase.
    Open

        function apache_request_headers()
    {
        $arh = array();

        foreach ($_SERVER as $key => $val) {
    Severity: Minor
    Found in src/Compat.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $arh_key is not named in camelCase.
    Open

        function apache_request_headers()
    {
        $arh = array();

        foreach ($_SERVER as $key => $val) {
    Severity: Minor
    Found in src/Compat.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $arh_key is not named in camelCase.
    Open

        function apache_request_headers()
    {
        $arh = array();

        foreach ($_SERVER as $key => $val) {
    Severity: Minor
    Found in src/Compat.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status