nabble/ajde

Method getTransactionOptions has 147 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function getTransactionOptions()
    {
        $options = new Ajde_Crud_Options();
        $options
            ->selectFields()

The method getTransactionOptions() has 152 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    public static function getTransactionOptions()
    {
        $options = new Ajde_Crud_Options();
        $options
            ->selectFields()

• Exclude checks
  • Disable engine
  • Disable check

Missing class import via use statement (line '35', column '28').

Open

        $transaction = new TransactionModel();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '59', column '24').

Open

        $options = new Ajde_Crud_Options();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class 'Ajde_Component_String' in method 'markPaidJson'.

Open

            'message' => Ajde_Component_String::makePlural($c, 'transaction').' marked as paid',

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid variables with short names like $c. Configured minimum length is 3.

Open

        $c = 0;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

        $id = Ajde::app()->getRequest()->getPostParam('id', false);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}