core/modules/admin/model/LogModel.php
Avoid too many return statements within this method. Open
Open
return 'icon-globe';Avoid too many return statements within this method. Open
Open
return 'icon-info-sign';Missing class import via use statement (line '7', column '54'). Open
Open
$controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('admin/system:logpanel'));- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'Ajde_Controller' in method 'displayPanel'. Open
Open
$controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('admin/system:logpanel'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}