core/modules/email/model/EmailModel.php
The method getTemplate has a boolean flag argument $useLang, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function getTemplate($useLang = false)
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The property $_displayField is not named in camelCase. Open
Open
class EmailModel extends Ajde_Model
{
protected $_autoloadParents = true;
protected $_displayField = 'name';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_autoloadParents is not named in camelCase. Open
Open
class EmailModel extends Ajde_Model
{
protected $_autoloadParents = true;
protected $_displayField = 'name';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}