core/modules/form/model/SubmissionModel.php
Missing class import via use statement (line '12', column '26'). Open
Open
$timestamp = new DateTime($this->get('added'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'Ajde_Component_String' in method 'displayAgo'. Open
Open
return Ajde_Component_String::time2str($timestamp);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The property $_autoloadParents is not named in camelCase. Open
Open
class SubmissionModel extends Ajde_Model
{
protected $_autoloadParents = true;
protected $_displayField = 'id';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_displayField is not named in camelCase. Open
Open
class SubmissionModel extends Ajde_Model
{
protected $_autoloadParents = true;
protected $_displayField = 'id';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_jsonFields is not named in camelCase. Open
Open
class SubmissionModel extends Ajde_Model
{
protected $_autoloadParents = true;
protected $_displayField = 'id';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}