core/modules/shop/model/ShippingModel.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method isEUCountry has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function isEUCountry($country)
    {
        $eu_countries = [
            'albania',
            'andorra',
Severity: Major
Found in core/modules/shop/model/ShippingModel.php - About 2 hrs to fix

    Missing class import via use statement (line '15', column '38').
    Open

                    $this->addMethod(new PickupModel());

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '11', column '30').
    Open

            $this->addMethod(new TntModel());

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The variable $eu_countries is not named in camelCase.
    Open

        public static function isEUCountry($country)
        {
            $eu_countries = [
                'albania',
                'andorra',

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $eu_countries is not named in camelCase.
    Open

        public static function isEUCountry($country)
        {
            $eu_countries = [
                'albania',
                'andorra',

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status