Sign upLogin

nabble/ajde

View on GitHub
Star
lib/Ajde/Acl/Collection.php

Summary

Maintainability
A
2 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

            if (
                (
                    ($rule->get('type') === 'public' && $type === 'public') ||
                    ($rule->get('type') === $type && $rule->get($type) === $ugId)
                )
Severity: Major
Found in lib/Ajde/Acl/Collection.php - About 1 hr to fix

    Method findRule has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function findRule($type, $ugId, $module, $action, $extra)
    Severity: Minor
    Found in lib/Ajde/Acl/Collection.php - About 35 mins to fix

      Function findRule has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function findRule($type, $ugId, $module, $action, $extra)
    {
        foreach ($this as $rule) {
            if (
                (
      Severity: Minor
      Found in lib/Ajde/Acl/Collection.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '31', column '37').
      Open

              return $this->addFilter(new Ajde_Filter_Where('entity', Ajde_Filter::FILTER_EQUALS, $entity));
      Severity: Minor
      Found in lib/Ajde/Acl/Collection.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The class Ajde_Acl_Collection is not named in CamelCase.
      Open

      class Ajde_Acl_Collection extends Ajde_Collection
{
    public function findRule($type, $ugId, $module, $action, $extra)
    {
        foreach ($this as $rule) {
      Severity: Minor
      Found in lib/Ajde/Acl/Collection.php by phpmd

      CamelCaseClassName

      Since: 0.2

      It is considered best practice to use the CamelCase notation to name classes.

      Example

      class class_name {
}

      Source

      There are no issues that match your filters.

      Category
      Status