lib/Ajde/Api/Controller.php
Function beforeInvoke
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
public function beforeInvoke($allowed = [])
{
$token = Ajde::app()->getRequest()->getParam('token', false);
if ($token) {
$user = new UserModel();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '9', column '25'). Open
Open
$user = new UserModel();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'UserModel' in method 'beforeInvoke'. Open
Open
$user = UserModel::getLoggedIn();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The class Ajde_Api_Controller is not named in CamelCase. Open
Open
abstract class Ajde_Api_Controller extends Ajde_Acl_Controller
{
public function beforeInvoke($allowed = [])
{
$token = Ajde::app()->getRequest()->getParam('token', false);
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}