lib/Ajde/Component/Form.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method process has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process()
    {
        switch ($this->_attributeParse()) {
            case 'form':
                $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:form'));
Severity: Minor
Found in lib/Ajde/Component/Form.php - About 1 hr to fix

    Function process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function process()
        {
            switch ($this->_attributeParse()) {
                case 'form':
                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:form'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '26', column '62').
    Open

                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:form'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '56', column '31').
    Open

                        throw new Ajde_Component_Exception('Options saveDir and extensions must be set for AC.Form.Upload');
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '49', column '62').
    Open

                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:formUpload'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '74', column '19').
    Open

            throw new Ajde_Component_Exception();
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '37', column '35').
    Open

                    $formAction = new Ajde_Core_Route($this->attributes['route']);
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '36', column '62').
    Open

                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:formAjax'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '67', column '62').
    Open

                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('form/view.html'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '8', column '18').
    Open

            $t = new stdClass(); // Force unique object hash, see http://www.php.net/manual/es/function.spl-object-hash.php#76220
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'Ajde_Controller' in method 'process'.
    Open

                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:formAjax'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Ajde_Controller' in method 'process'.
    Open

                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:formUpload'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Ajde_Controller' in method 'process'.
    Open

                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('form/view.html'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Ajde_Controller' in method 'process'.
    Open

                    $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:form'));
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused local variables such as '$t'.
    Open

            $t = new stdClass(); // Force unique object hash, see http://www.php.net/manual/es/function.spl-object-hash.php#76220
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    TODO found
    Open

            // TODO:
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by fixme

    TODO found
    Open

                        // TODO:
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by fixme

    The class Ajde_Component_Form is not named in CamelCase.
    Open

    class Ajde_Component_Form extends Ajde_Component
    {
        public static function processStatic(Ajde_Template_Parser $parser, $attributes)
        {
            $instance = new self($parser, $attributes);
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
    }

    Source

    Avoid variables with short names like $t. Configured minimum length is 3.
    Open

            $t = new stdClass(); // Force unique object hash, see http://www.php.net/manual/es/function.spl-object-hash.php#76220
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    The method _init is not named in camelCase.
    Open

        protected function _init()
        {
            return [
                'ajax'   => 'ajax',
                'route'  => 'form',
    Severity: Minor
    Found in lib/Ajde/Component/Form.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status