lib/Ajde/Component/Qrcode.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '23', column '27').
Open

                $qr = new Ajde_Resource_Qrcode($this->attributes['text']);
Severity: Minor
Found in lib/Ajde/Component/Qrcode.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '25', column '62').
Open

                $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:qrcode'));
Severity: Minor
Found in lib/Ajde/Component/Qrcode.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '32', column '19').
Open

        throw new Ajde_Component_Exception('Missing required attributes for component call');
Severity: Minor
Found in lib/Ajde/Component/Qrcode.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'Ajde_Controller' in method 'process'.
Open

                $controller = Ajde_Controller::fromRoute(new Ajde_Core_Route('_core/component:qrcode'));
Severity: Minor
Found in lib/Ajde/Component/Qrcode.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

TODO found
Open

        // TODO:
Severity: Minor
Found in lib/Ajde/Component/Qrcode.php by fixme

The class Ajde_Component_Qrcode is not named in CamelCase.
Open

class Ajde_Component_Qrcode extends Ajde_Component
{
    public static function processStatic(Ajde_Template_Parser $parser, $attributes)
    {
        $instance = new self($parser, $attributes);
Severity: Minor
Found in lib/Ajde/Component/Qrcode.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Avoid variables with short names like $qr. Configured minimum length is 3.
Open

                $qr = new Ajde_Resource_Qrcode($this->attributes['text']);
Severity: Minor
Found in lib/Ajde/Component/Qrcode.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The method _init is not named in camelCase.
Open

    protected function _init()
    {
        return [
            'text' => 'html',
        ];
Severity: Minor
Found in lib/Ajde/Component/Qrcode.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status