Sign upLogin

nabble/ajde

View on GitHub
Star
lib/Ajde/Core/Route.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method _extractRouteParts has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _extractRouteParts()
    {
        $matches = [];
        $defaultRules = [
            // module/controller:view
Severity: Minor
Found in lib/Ajde/Core/Route.php - About 1 hr to fix

    Method __construct has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($route)
    {
        $this->_originalRoute = $route;
        // See if first part is language code (i.e. first part is exactly
        // two characters in length)
    Severity: Minor
    Found in lib/Ajde/Core/Route.php - About 1 hr to fix

      Function __construct has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct($route)
    {
        $this->_originalRoute = $route;
        // See if first part is language code (i.e. first part is exactly
        // two characters in length)
      Severity: Minor
      Found in lib/Ajde/Core/Route.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _extractRouteParts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _extractRouteParts()
    {
        $matches = [];
        $defaultRules = [
            // module/controller:view
      Severity: Minor
      Found in lib/Ajde/Core/Route.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '126', column '23').
      Open

                  throw new Ajde_Core_Exception_Deprecated();
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method buildRoute has a boolean flag argument $includeLang, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function buildRoute($includeLang = true)
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '90', column '23').
      Open

                  throw new Ajde_Core_Exception_Deprecated();
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '38', column '30').
      Open

                  $exception = new Ajde_Core_Exception_Routing(sprintf('Invalid route: %s',
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '108', column '23').
      Open

                  throw new Ajde_Core_Exception_Deprecated();
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '99', column '23').
      Open

                  throw new Ajde_Core_Exception_Deprecated();
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '117', column '23').
      Open

                  throw new Ajde_Core_Exception_Deprecated();
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '192', column '31').
      Open

                          throw new Ajde_Exception('Number of routeparts does not match regular expression', 90020);
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid assigning values to variables in if clauses and the like (line '16', column '17').
      Open

          public function __construct($route)
    {
        $this->_originalRoute = $route;
        // See if first part is language code (i.e. first part is exactly
        // two characters in length)
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid using static access to class 'Ajde_Lang' in method '__construct'.
      Open

                  $langInstance = Ajde_Lang::getInstance();
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Ajde' in method '__construct'.
      Open

                  Ajde::routingError($exception);
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $this->_route = $route;
        }
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class 'Ajde_Event' in method '__construct'.
      Open

              Ajde_Event::trigger($this, 'onAfterRouteSet');
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Ajde_Event' in method '__construct'.
      Open

              Ajde_Event::trigger($this, 'onAfterLangSet');
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The class Ajde_Core_Route is not named in CamelCase.
      Open

      class Ajde_Core_Route extends Ajde_Object_Standard
{
    protected $_originalRoute = null;
    protected $_route = null;
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      CamelCaseClassName

      Since: 0.2

      It is considered best practice to use the CamelCase notation to name classes.

      Example

      class class_name {
}

      Source

      The property $_originalRoute is not named in camelCase.
      Open

      class Ajde_Core_Route extends Ajde_Object_Standard
{
    protected $_originalRoute = null;
    protected $_route = null;
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
    protected $property_name;
}

      Source

      The property $_route is not named in camelCase.
      Open

      class Ajde_Core_Route extends Ajde_Object_Standard
{
    protected $_originalRoute = null;
    protected $_route = null;
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
    protected $property_name;
}

      Source

      The method _extractRouteParts is not named in camelCase.
      Open

          protected function _extractRouteParts()
    {
        $matches = [];
        $defaultRules = [
            // module/controller:view
      Severity: Minor
      Found in lib/Ajde/Core/Route.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status