Ajde_Crud_Field
has 27 functions (exceeds 20 allowed). Consider refactoring. Open
abstract class Ajde_Crud_Field extends Ajde_Object_Standard
{
/**
* @var Ajde_Crud
*/
Function getHtmlAttributesAsArray
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
public function getHtmlAttributesAsArray()
{
if (empty($this->_attributes)) {
$attributes = [];
if (method_exists($this, '_getHtmlAttributes')) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getHtmlAttributesAsArray
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getHtmlAttributesAsArray()
{
if (empty($this->_attributes)) {
$attributes = [];
if (method_exists($this, '_getHtmlAttributes')) {
Missing class import via use statement (line '146', column '29'). Open
$template = new Ajde_Template(MODULE_DIR.'_core/', 'crud/'.$action);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '158', column '23'). Open
throw new Ajde_Exception('No crud template found for field '.$action);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '152', column '29'). Open
$template = new Ajde_Template($base, $action);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method getHtmlAttributesAsArray uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$attributes['class'] = $this->getClass();
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method _getTemplate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// TODO:
throw new Ajde_Exception('No crud template found for field '.$action);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'Ajde_Template' in method '_getTemplate'. Open
if (Ajde_Template::exist(MODULE_DIR.'_core/', 'crud/'.$action) !== false) {
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Ajde_Template' in method '_hasCustomTemplate'. Open
return Ajde_Template::exist($base, $action) !== false;
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getHtmlAttributesAsArray uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$attributes['class'] = 'span'.$this->_useSpan;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method getValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return false;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
TODO found Open
// TODO:
- Exclude checks
The class Ajde_Crud_Field is not named in CamelCase. Open
abstract class Ajde_Crud_Field extends Ajde_Object_Standard
{
/**
* @var Ajde_Crud
*/
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
The property $_type is not named in camelCase. Open
abstract class Ajde_Crud_Field extends Ajde_Object_Standard
{
/**
* @var Ajde_Crud
*/
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_crud is not named in camelCase. Open
abstract class Ajde_Crud_Field extends Ajde_Object_Standard
{
/**
* @var Ajde_Crud
*/
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_attributes is not named in camelCase. Open
abstract class Ajde_Crud_Field extends Ajde_Object_Standard
{
/**
* @var Ajde_Crud
*/
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
Avoid variables with short names like $id. Configured minimum length is 3. Open
public function getInput($id = null)
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The property $_useSpan is not named in camelCase. Open
abstract class Ajde_Crud_Field extends Ajde_Object_Standard
{
/**
* @var Ajde_Crud
*/
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The method _getFieldTemplate is not named in camelCase. Open
protected function _getFieldTemplate()
{
return $this->_getTemplate('field');
}
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method _getCustomTemplateBase is not named in camelCase. Open
protected function _getCustomTemplateBase()
{
return MODULE_DIR.$this->_crud->getCustomTemplateModule().'/';
}
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method _getInputTemplate is not named in camelCase. Open
protected function _getInputTemplate()
{
return $this->_getTemplate('field/'.$this->_type);
}
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method _getTemplate is not named in camelCase. Open
protected function _getTemplate($action)
{
$template = null;
if (Ajde_Template::exist(MODULE_DIR.'_core/', 'crud/'.$action) !== false) {
$template = new Ajde_Template(MODULE_DIR.'_core/', 'crud/'.$action);
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method _hasCustomTemplate is not named in camelCase. Open
protected function _hasCustomTemplate($action)
{
$base = $this->_getCustomTemplateBase();
$action = $this->_getCustomTemplateAction($action);
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method _getCustomTemplateAction is not named in camelCase. Open
protected function _getCustomTemplateAction($action)
{
return 'crud/'.(string) $this->_crud->getModel()->getTable().'/'.$action;
}
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}