lib/Ajde/Crud/Field/I18n.php

Summary

Maintainability
A
25 mins
Test Coverage

Function getAvailableTranslations has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAvailableTranslations()
    {
        $lang = Ajde_Lang::getInstance();
        $langs = $lang->getAvailableNiceNames();

Severity: Minor
Found in lib/Ajde/Crud/Field/I18n.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using static access to class 'Ajde_Lang' in method 'getAvailableTranslations'.
Open

        $lang = Ajde_Lang::getInstance();
Severity: Minor
Found in lib/Ajde/Crud/Field/I18n.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Ajde_Lang' in method 'getValues'.
Open

        $lang = Ajde_Lang::getInstance();
Severity: Minor
Found in lib/Ajde/Crud/Field/I18n.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The class Ajde_Crud_Field_I18n is not named in CamelCase.
Open

class Ajde_Crud_Field_I18n extends Ajde_Crud_Field_Enum
{
    protected $_useSpan = false;

    public function __construct(Ajde_Crud $crud, $fieldOptions)
Severity: Minor
Found in lib/Ajde/Crud/Field/I18n.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The property $_useSpan is not named in camelCase.
Open

class Ajde_Crud_Field_I18n extends Ajde_Crud_Field_Enum
{
    protected $_useSpan = false;

    public function __construct(Ajde_Crud $crud, $fieldOptions)
Severity: Minor
Found in lib/Ajde/Crud/Field/I18n.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The method _getHtmlAttributes is not named in camelCase.
Open

    public function _getHtmlAttributes()
    {
        $attributes = [];
        $attributes['class'] = 'lang';

Severity: Minor
Found in lib/Ajde/Crud/Field/I18n.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status