lib/Ajde/Crud/Options/Fields.php
The method up has a boolean flag argument $obj, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function up($obj = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid unused parameters such as '$obj'. Open
Open
public function up($obj = false)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid using short method names like Ajde_Crud_Options_Fields::up(). The configured minimum method name length is 3. Open
Open
public function up($obj = false)
{
return parent::up($this);
}- Read upRead up
- Exclude checks
ShortMethodName
Since: 0.2
Detects when very short method names are used.
Example
class ShortMethod {
public function a( $index ) { // Violation
}
}Source https://phpmd.org/rules/naming.html#shortmethodname
The class Ajde_Crud_Options_Fields is not named in CamelCase. Open
Open
class Ajde_Crud_Options_Fields extends Ajde_Crud_Options
{
/**
* @return Ajde_Crud_Options
*/- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}