nabble/ajde

Ajde_Crud_Options_List_View has 25 functions (exceeds 20 allowed). Consider refactoring.

Open

class Ajde_Crud_Options_List_View extends Ajde_Crud_Options
{
    /**
     * @return Ajde_Crud_Options_List
     */

The method up has a boolean flag argument $obj, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function up($obj = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid unused parameters such as '$obj'.

Open

    public function up($obj = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid using short method names like Ajde_Crud_Options_List_View::up(). The configured minimum method name length is 3.

Open

    public function up($obj = false)
    {
        return parent::up($this);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Avoid variables with short names like $q. Configured minimum length is 3.

Open

    public function setSearch($q)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The class Ajde_Crud_Options_List_View is not named in CamelCase.

Open

class Ajde_Crud_Options_List_View extends Ajde_Crud_Options
{
    /**
     * @return Ajde_Crud_Options_List
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}