The method getCache uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
TODO found Open
// TODO: precision and limits- Exclude checks
TODO found Open
// TODO: Quite naive, rough implementation- Exclude checks
The property $_connection is not named in camelCase. Open
class Ajde_Db_Adapter_Mysql extends Ajde_Db_Adapter_Abstract
{
protected $_connection = null;
protected $_dbname = null;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $_cache is not named in camelCase. Open
class Ajde_Db_Adapter_Mysql extends Ajde_Db_Adapter_Abstract
{
protected $_connection = null;
protected $_dbname = null;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The class Ajde_Db_Adapter_Mysql is not named in CamelCase. Open
class Ajde_Db_Adapter_Mysql extends Ajde_Db_Adapter_Abstract
{
protected $_connection = null;
protected $_dbname = null;
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
The property $_dbname is not named in camelCase. Open
class Ajde_Db_Adapter_Mysql extends Ajde_Db_Adapter_Abstract
{
protected $_connection = null;
protected $_dbname = null;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The variable $_cache is not named in camelCase. Open
public static function saveCache($sql, $result)
{
self::$_cache[$sql] = $result;
return $result;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_cache is not named in camelCase. Open
public static function getCache($sql)
{
if (array_key_exists($sql, self::$_cache)) {
return self::$_cache[$sql];
} else {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}