lib/Ajde/Db/Table.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function getFieldProperties has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function getFieldProperties($fieldName = null, $property = null)
    {
        if (isset($fieldName)) {
            if (isset($this->_fields[$fieldName])) {
                if (isset($property)) {
Severity: Minor
Found in lib/Ajde/Db/Table.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initTableStructure has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function initTableStructure()
    {
        $structure = Ajde_Db::getInstance()->getAdapter()->getTableStructure($this->_name);
        foreach ($structure as $field) {
            $fieldName = $field['Field'];
Severity: Minor
Found in lib/Ajde/Db/Table.php - About 1 hr to fix

    The method getFieldProperties uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                        return $this->_fields[$fieldName];
                    }
    Severity: Minor
    Found in lib/Ajde/Db/Table.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method getFieldProperties uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                return $this->_fields;
            }
    Severity: Minor
    Found in lib/Ajde/Db/Table.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid variables with short names like $fk. Configured minimum length is 3.
    Open

            $fk = Ajde_Db::getInstance()->getAdapter()->getForeignKey((string) $this, (string) $column);
    Severity: Minor
    Found in lib/Ajde/Db/Table.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    The property $_fields is not named in camelCase.
    Open

    class Ajde_Db_Table extends Ajde_Object_Standard
    {
        protected $_connection;
        protected $_name;
        protected $_fields;
    Severity: Minor
    Found in lib/Ajde/Db/Table.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
        protected $property_name;
    }

    Source

    The property $_name is not named in camelCase.
    Open

    class Ajde_Db_Table extends Ajde_Object_Standard
    {
        protected $_connection;
        protected $_name;
        protected $_fields;
    Severity: Minor
    Found in lib/Ajde/Db/Table.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
        protected $property_name;
    }

    Source

    The property $_connection is not named in camelCase.
    Open

    class Ajde_Db_Table extends Ajde_Object_Standard
    {
        protected $_connection;
        protected $_name;
        protected $_fields;
    Severity: Minor
    Found in lib/Ajde/Db/Table.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
        protected $property_name;
    }

    Source

    The class Ajde_Db_Table is not named in CamelCase.
    Open

    class Ajde_Db_Table extends Ajde_Object_Standard
    {
        protected $_connection;
        protected $_name;
        protected $_fields;
    Severity: Minor
    Found in lib/Ajde/Db/Table.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
    }

    Source

    There are no issues that match your filters.

    Category
    Status