lib/Ajde/Document/Format/Css.php
Missing class import via use statement (line '10', column '51'). Open
Open
Ajde::app()->getDocument()->setLayout(new Ajde_Layout('empty'));- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method render uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$this->registerDocumentProcessor('css');
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The property $_contentType is not named in camelCase. Open
Open
class Ajde_Document_Format_Css extends Ajde_Document
{
protected $_cacheControl = self::CACHE_CONTROL_PUBLIC;
protected $_contentType = 'text/css';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The class Ajde_Document_Format_Css is not named in CamelCase. Open
Open
class Ajde_Document_Format_Css extends Ajde_Document
{
protected $_cacheControl = self::CACHE_CONTROL_PUBLIC;
protected $_contentType = 'text/css';
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
The property $_cacheControl is not named in camelCase. Open
Open
class Ajde_Document_Format_Css extends Ajde_Document
{
protected $_cacheControl = self::CACHE_CONTROL_PUBLIC;
protected $_contentType = 'text/css';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}