lib/Ajde/Document/Format/Json.php

Summary

Maintainability
A
25 mins
Test Coverage

Function getBody has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getBody()
    {
        $body = json_encode($this->get('body'));
        if (config('app.debug')) {
            if (Ajde_Dump::getAll()) {
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '12', column '51').
Open

        Ajde::app()->getDocument()->setLayout(new Ajde_Layout('empty'));
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'Ajde_Dump' in method 'getBody'.
Open

            if (Ajde_Dump::getAll()) {
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Ajde_Dump' in method 'getBody'.
Open

                foreach (Ajde_Dump::getAll() as $source => $var) {
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$source'.
Open

                foreach (Ajde_Dump::getAll() as $source => $var) {
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The class Ajde_Document_Format_Json is not named in CamelCase.
Open

class Ajde_Document_Format_Json extends Ajde_Document
{
    protected $_cacheControl = self::CACHE_CONTROL_NOCACHE;
    protected $_contentType = 'application/json';
    protected $_maxAge = 0; // access
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The property $_maxAge is not named in camelCase.
Open

class Ajde_Document_Format_Json extends Ajde_Document
{
    protected $_cacheControl = self::CACHE_CONTROL_NOCACHE;
    protected $_contentType = 'application/json';
    protected $_maxAge = 0; // access
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $_contentType is not named in camelCase.
Open

class Ajde_Document_Format_Json extends Ajde_Document
{
    protected $_cacheControl = self::CACHE_CONTROL_NOCACHE;
    protected $_contentType = 'application/json';
    protected $_maxAge = 0; // access
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $_cacheControl is not named in camelCase.
Open

class Ajde_Document_Format_Json extends Ajde_Document
{
    protected $_cacheControl = self::CACHE_CONTROL_NOCACHE;
    protected $_contentType = 'application/json';
    protected $_maxAge = 0; // access
Severity: Minor
Found in lib/Ajde/Document/Format/Json.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There are no issues that match your filters.

Category
Status