Function trigger
has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring. Open
public static function trigger($object, $event, array $parameters = [])
{
foreach (self::$eventStack as $className => $eventStack) {
if (self::className($object) == $className ||
is_subclass_of(self::className($object), $className)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method trigger
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function trigger($object, $event, array $parameters = [])
{
foreach (self::$eventStack as $className => $eventStack) {
if (self::className($object) == $className ||
is_subclass_of(self::className($object), $className)
The method trigger() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open
public static function trigger($object, $event, array $parameters = [])
{
foreach (self::$eventStack as $className => $eventStack) {
if (self::className($object) == $className ||
is_subclass_of(self::className($object), $className)
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '94', column '43'). Open
throw new Ajde_Exception('Event context needed to
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '117', column '19'). Open
throw new Ajde_Exception('No classname or object instance given, or classname is incorrect', 90012);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '102', column '39'). Open
throw new Ajde_Exception('Callback is not valid', 90016);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method trigger uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
throw new Ajde_Exception('Event context needed to
fire, none detected', 90015);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method has uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return isset(self::$eventStack[self::className($object)][$event]);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method trigger uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// TODO: right now never fires in Object_Magic objects
// because of the __call magic function. Workaround
// could be something like in_array("bar",get_class_methods($f1)
// see: http://php.net/manual/en/function.method-exists.php
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$current'. Open
$current = array_shift($trace);
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
TODO found Open
// TODO: Aborts execution of cueue!
- Exclude checks
TODO found Open
// TODO: update exception 90015
- Exclude checks
TODO found Open
// TODO: right now never fires in Object_Magic objects
- Exclude checks
TODO found Open
// TODO: Aborts execution of cueue!
- Exclude checks
TODO found Open
// TODO: Aborts execution of cueue!
- Exclude checks
The class Ajde_Event is not named in CamelCase. Open
class Ajde_Event extends Ajde_Object_Static
{
protected static $eventStack = [];
/**
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}