lib/Ajde/Exception.php
The method __construct has a boolean flag argument $traceOnOutput, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct($message = null, $code = 0, $traceOnOutput = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class 'Ajde_Exception_Handler' in method 'process'. Open
Open
return Ajde_Exception_Handler::handler($this);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The class Ajde_Exception is not named in CamelCase. Open
Open
class Ajde_Exception extends Exception
{
protected $_traceOnOutput = true;
public function __construct($message = null, $code = 0, $traceOnOutput = true)- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
The property $_traceOnOutput is not named in camelCase. Open
Open
class Ajde_Exception extends Exception
{
protected $_traceOnOutput = true;
public function __construct($message = null, $code = 0, $traceOnOutput = true)- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}