lib/Ajde/Filter/Join.php
Avoid unused parameters such as '$table'. Open
Open
public function prepare(Ajde_Db_Table $table = null)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The property $_table is not named in camelCase. Open
Open
class Ajde_Filter_Join extends Ajde_Filter
{
protected $_table;
protected $_ownerField;
protected $_childField;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The class Ajde_Filter_Join is not named in CamelCase. Open
Open
class Ajde_Filter_Join extends Ajde_Filter
{
protected $_table;
protected $_ownerField;
protected $_childField;- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
The property $_ownerField is not named in camelCase. Open
Open
class Ajde_Filter_Join extends Ajde_Filter
{
protected $_table;
protected $_ownerField;
protected $_childField;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $_childField is not named in camelCase. Open
Open
class Ajde_Filter_Join extends Ajde_Filter
{
protected $_table;
protected $_ownerField;
protected $_childField;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}