The method prepare uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$useTable = (string) $table;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The property $_fields is not named in camelCase. Open
class Ajde_Filter_Match extends Ajde_Filter
{
protected $_fields;
protected $_against;
protected $_operator;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $_table is not named in camelCase. Open
class Ajde_Filter_Match extends Ajde_Filter
{
protected $_fields;
protected $_against;
protected $_operator;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $_operator is not named in camelCase. Open
class Ajde_Filter_Match extends Ajde_Filter
{
protected $_fields;
protected $_against;
protected $_operator;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The class Ajde_Filter_Match is not named in CamelCase. Open
class Ajde_Filter_Match extends Ajde_Filter
{
protected $_fields;
protected $_against;
protected $_operator;- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
The property $_against is not named in camelCase. Open
class Ajde_Filter_Match extends Ajde_Filter
{
protected $_fields;
protected $_against;
protected $_operator;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}