lib/Ajde/Filter/MatchGroup.php
Function prepare
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
public function prepare(Ajde_Db_Table $table = null)
{
$sqlWhere = '';
$select = [];
$first = true;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method prepare
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function prepare(Ajde_Db_Table $table = null)
{
$sqlWhere = '';
$select = [];
$first = true;
The class Ajde_Filter_MatchGroup is not named in CamelCase. Open
Open
class Ajde_Filter_MatchGroup extends Ajde_Filter
{
protected $_filters;
protected $_operator;
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
The property $_operator is not named in camelCase. Open
Open
class Ajde_Filter_MatchGroup extends Ajde_Filter
{
protected $_filters;
protected $_operator;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_filters is not named in camelCase. Open
Open
class Ajde_Filter_MatchGroup extends Ajde_Filter
{
protected $_filters;
protected $_operator;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}