lib/Ajde/Filter/Where.php

Summary

Maintainability
A
3 hrs
Test Coverage

The method prepare uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $sql = $this->_field.$this->_comparison.':'.spl_object_hash($this);
            $values = [spl_object_hash($this) => $this->_value];
        }
Severity: Minor
Found in lib/Ajde/Filter/Where.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$table'.
Open

    public function prepare(Ajde_Db_Table $table = null)
Severity: Minor
Found in lib/Ajde/Filter/Where.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function prepare(Ajde_Db_Table $table = null)
    {
        $values = [];
        if ($this->_value instanceof Ajde_Db_Function) {
            $sql = $this->_field.$this->_comparison.(string) $this->_value;
Severity: Major
Found in lib/Ajde/Filter/Where.php and 1 other location - About 3 hrs to fix
lib/Ajde/Filter/Having.php on lines 10..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 143.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The property $_field is not named in camelCase.
Open

class Ajde_Filter_Where extends Ajde_Filter
{
    protected $_field;
    protected $_comparison;
    protected $_value;
Severity: Minor
Found in lib/Ajde/Filter/Where.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $_operator is not named in camelCase.
Open

class Ajde_Filter_Where extends Ajde_Filter
{
    protected $_field;
    protected $_comparison;
    protected $_value;
Severity: Minor
Found in lib/Ajde/Filter/Where.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $_value is not named in camelCase.
Open

class Ajde_Filter_Where extends Ajde_Filter
{
    protected $_field;
    protected $_comparison;
    protected $_value;
Severity: Minor
Found in lib/Ajde/Filter/Where.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $_comparison is not named in camelCase.
Open

class Ajde_Filter_Where extends Ajde_Filter
{
    protected $_field;
    protected $_comparison;
    protected $_value;
Severity: Minor
Found in lib/Ajde/Filter/Where.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The class Ajde_Filter_Where is not named in CamelCase.
Open

class Ajde_Filter_Where extends Ajde_Filter
{
    protected $_field;
    protected $_comparison;
    protected $_value;
Severity: Minor
Found in lib/Ajde/Filter/Where.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

There are no issues that match your filters.

Category
Status