getLanguagesFromHeader accesses the super-global variable $_SERVER. Open
protected function getLanguagesFromHeader()
{
// @source http://www.thefutureoftheweb.com/blog/use-accept-language-header
$langs = [];
if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
getLanguagesFromHeader accesses the super-global variable $_SERVER. Open
protected function getLanguagesFromHeader()
{
// @source http://www.thefutureoftheweb.com/blog/use-accept-language-header
$langs = [];
if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
File Lang.php
has 336 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
class Ajde_Lang extends Ajde_Object_Singleton
{
protected $_adapter = null;
Ajde_Lang
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class Ajde_Lang extends Ajde_Object_Singleton
{
protected $_adapter = null;
protected $_lang;
Function getLanguagesFromHeader
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function getLanguagesFromHeader()
{
// @source http://www.thefutureoftheweb.com/blog/use-accept-language-header
$langs = [];
if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function detect
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
protected function detect()
{
if (config('i18n.autodetect')) {
$acceptedLangs = $this->getLanguagesFromHeader();
foreach ($acceptedLangs as $acceptedLang => $priority) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '368', column '19'). Open
throw new Ajde_Core_Exception_Deprecated('Use Ajde_Lang::translate() instead');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid assigning values to variables in if clauses and the like (line '269', column '21'). Open
protected function detect()
{
if (config('i18n.autodetect')) {
$acceptedLangs = $this->getLanguagesFromHeader();
foreach ($acceptedLangs as $acceptedLang => $priority) {
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class 'Ajde_Fs_Find' in method 'getAvailable'. Open
$langs = Ajde_Fs_Find::findFiles(LANG_DIR, '*');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Ajde_Fs_Find' in method 'getAvailableNiceNames'. Open
$langs = Ajde_Fs_Find::findFiles(LANG_DIR, '*');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Config' in method 'setGlobalLang'. Open
Config::set('i18n.rootUrl', config('app.rootUrl').$this->getShortLang().'/');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused local variables such as '$priority'. Open
foreach ($acceptedLangs as $acceptedLang => $priority) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused parameters such as '$module'. Open
public function get($ident, $module = null)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused local variables such as '$defaultLang'. Open
return $defaultLang = config('i18n.default');
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused parameters such as '$ident'. Open
public function get($ident, $module = null)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
TODO found Open
// TODO:
- Exclude checks
Avoid excessively long variable names like $_autoTranslationOfModels. Keep variable name length under 20. Open
protected $_autoTranslationOfModels = true;
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
The property $_adapter is not named in camelCase. Open
class Ajde_Lang extends Ajde_Object_Singleton
{
protected $_adapter = null;
protected $_lang;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_lang is not named in camelCase. Open
class Ajde_Lang extends Ajde_Object_Singleton
{
protected $_adapter = null;
protected $_lang;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_niceNames is not named in camelCase. Open
class Ajde_Lang extends Ajde_Object_Singleton
{
protected $_adapter = null;
protected $_lang;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_autoTranslationOfModels is not named in camelCase. Open
class Ajde_Lang extends Ajde_Object_Singleton
{
protected $_adapter = null;
protected $_lang;
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The class Ajde_Lang is not named in CamelCase. Open
class Ajde_Lang extends Ajde_Object_Singleton
{
protected $_adapter = null;
protected $_lang;
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
The variable $lang_parse is not named in camelCase. Open
protected function getLanguagesFromHeader()
{
// @source http://www.thefutureoftheweb.com/blog/use-accept-language-header
$langs = [];
if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lang_parse is not named in camelCase. Open
protected function getLanguagesFromHeader()
{
// @source http://www.thefutureoftheweb.com/blog/use-accept-language-header
$langs = [];
if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lang_parse is not named in camelCase. Open
protected function getLanguagesFromHeader()
{
// @source http://www.thefutureoftheweb.com/blog/use-accept-language-header
$langs = [];
if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lang_parse is not named in camelCase. Open
protected function getLanguagesFromHeader()
{
// @source http://www.thefutureoftheweb.com/blog/use-accept-language-header
$langs = [];
if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $_niceNames is not named in camelCase. Open
public static function niceName($lang)
{
return self::$_niceNames[substr(strtolower($lang), 0, 2)];
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}