Remove error control operator '@' on line 18. Open
public static function inlineCss($html)
{
$url = 'http://premailer.dialect.ca/api/0.1/documents';
$data = [
'html' => $html,- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Avoid using static access to class 'Ajde_Http_Curl' in method 'inlineCss'. Open
$json = Ajde_Http_Curl::post($url, $data);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Ajde_Http_Curl' in method 'inlineCss'. Open
return Ajde_Http_Curl::get($url);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The class Ajde_Mailer_CssInliner_Dialect is not named in CamelCase. Open
class Ajde_Mailer_CssInliner_Dialect implements Ajde_Mailer_CssInliner_CssInlinerInterface
{
/**
* @param string $html
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}