lib/Ajde/Model.php

Summary

Maintainability
F
5 days
Test Coverage

File Model.php has 698 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class Ajde_Model extends Ajde_Object_Standard
{
    const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
Severity: Major
Found in lib/Ajde/Model.php - About 1 day to fix

    Ajde_Model has 72 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Ajde_Model extends Ajde_Object_Standard
    {
        const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
    
        protected $_connection;
    Severity: Major
    Found in lib/Ajde/Model.php - About 1 day to fix

      Function insert has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

          public function insert($pkValue = null, $skipBeforeInsert = false)
          {
              if (method_exists($this, 'beforeInsert') && $skipBeforeInsert === false) {
                  $this->beforeInsert();
              }
      Severity: Minor
      Found in lib/Ajde/Model.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
      Open

          public function save()
          {
              if (method_exists($this, 'beforeSave')) {
                  $this->beforeSave();
              }
      Severity: Minor
      Found in lib/Ajde/Model.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The class Ajde_Model has an overall complexity of 180 which is very high. The configured complexity threshold is 50.
      Open

      class Ajde_Model extends Ajde_Object_Standard
      {
          const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
      
          protected $_connection;
      Severity: Minor
      Found in lib/Ajde/Model.php by phpmd

      The class Ajde_Model has 39 non-getter- and setter-methods. Consider refactoring Ajde_Model to keep number of methods under 25.
      Open

      class Ajde_Model extends Ajde_Object_Standard
      {
          const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
      
          protected $_connection;
      Severity: Minor
      Found in lib/Ajde/Model.php by phpmd

      TooManyMethods

      Since: 0.1

      A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      The default was changed from 10 to 25 in PHPMD 2.3.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanymethods

      The class Ajde_Model has 33 public methods. Consider refactoring Ajde_Model to keep number of public methods under 10.
      Open

      class Ajde_Model extends Ajde_Object_Standard
      {
          const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
      
          protected $_connection;
      Severity: Minor
      Found in lib/Ajde/Model.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      Method insert has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function insert($pkValue = null, $skipBeforeInsert = false)
          {
              if (method_exists($this, 'beforeInsert') && $skipBeforeInsert === false) {
                  $this->beforeInsert();
              }
      Severity: Major
      Found in lib/Ajde/Model.php - About 2 hrs to fix

        Method save has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function save()
            {
                if (method_exists($this, 'beforeSave')) {
                    $this->beforeSave();
                }
        Severity: Major
        Found in lib/Ajde/Model.php - About 2 hrs to fix

          Function getMetaValues has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getMetaValues()
              {
                  if (empty($this->_metaValues)) {
                      $meta = [];
                      if ($this->hasLoaded()) {
          Severity: Minor
          Found in lib/Ajde/Model.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The class Ajde_Model has 66 public methods and attributes. Consider reducing the number of public items to less than 45.
          Open

          class Ajde_Model extends Ajde_Object_Standard
          {
              const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
          
              protected $_connection;
          Severity: Minor
          Found in lib/Ajde/Model.php by phpmd

          ExcessivePublicCount

          Since: 0.1

          A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.

          Example

          public class Foo {
              public $value;
              public $something;
              public $var;
              // [... more more public attributes ...]
          
              public function doWork() {}
              public function doMoreWork() {}
              public function doWorkAgain() {}
              // [... more more public methods ...]
          }

          Source https://phpmd.org/rules/codesize.html#excessivepubliccount

          Function _recurseChildren has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private function _recurseChildren(
                  $collection,
                  $collectionName,
                  $parentField,
                  $levelField,
          Severity: Minor
          Found in lib/Ajde/Model.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function validate($fieldOptions = [])
              {
                  if (method_exists($this, 'beforeValidate')) {
                      $return = $this->beforeValidate();
                      if ($return !== true && $return !== false) {
          Severity: Minor
          Found in lib/Ajde/Model.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _recurseChildren has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $collection,
                  $collectionName,
                  $parentField,
                  $levelField,
                  $sortField,
          Severity: Minor
          Found in lib/Ajde/Model.php - About 45 mins to fix

            Function getValues has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getValues($recursive = true)
                {
                    $return = [];
                    foreach ($this->_data as $k => $v) {
                        if ($v instanceof self) {
            Severity: Minor
            Found in lib/Ajde/Model.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            The method save() has an NPath complexity of 360. The configured NPath complexity threshold is 200.
            Open

                public function save()
                {
                    if (method_exists($this, 'beforeSave')) {
                        $this->beforeSave();
                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            NPathComplexity

            Since: 0.1

            The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

            Example

            class Foo {
                function bar() {
                    // lots of complicated code
                }
            }

            Source https://phpmd.org/rules/codesize.html#npathcomplexity

            The method insert() has an NPath complexity of 1872. The configured NPath complexity threshold is 200.
            Open

                public function insert($pkValue = null, $skipBeforeInsert = false)
                {
                    if (method_exists($this, 'beforeInsert') && $skipBeforeInsert === false) {
                        $this->beforeInsert();
                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            NPathComplexity

            Since: 0.1

            The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

            Example

            class Foo {
                function bar() {
                    // lots of complicated code
                }
            }

            Source https://phpmd.org/rules/codesize.html#npathcomplexity

            The method save() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
            Open

                public function save()
                {
                    if (method_exists($this, 'beforeSave')) {
                        $this->beforeSave();
                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The method insert() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10.
            Open

                public function insert($pkValue = null, $skipBeforeInsert = false)
                {
                    if (method_exists($this, 'beforeInsert') && $skipBeforeInsert === false) {
                        $this->beforeInsert();
                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The class Ajde_Model has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CouplingBetweenObjects

            Since: 1.1.0

            A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

            Example

            class Foo {
                /**
                 * @var \foo\bar\X
                 */
                private $x = null;
            
                /**
                 * @var \foo\bar\Y
                 */
                private $y = null;
            
                /**
                 * @var \foo\bar\Z
                 */
                private $z = null;
            
                public function setFoo(\Foo $foo) {}
                public function setBar(\Bar $bar) {}
                public function setBaz(\Baz $baz) {}
            
                /**
                 * @return \SplObjectStorage
                 * @throws \OutOfRangeException
                 * @throws \InvalidArgumentException
                 * @throws \ErrorException
                 */
                public function process(\Iterator $it) {}
            
                // ...
            }

            Source https://phpmd.org/rules/design.html#couplingbetweenobjects

            The method getValues has a boolean flag argument $recursive, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function getValues($recursive = true)
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method _load has a boolean flag argument $populate, which is a certain sign of a Single Responsibility Principle violation.
            Open

                protected function _load($sql, $values, $populate = true)
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            Remove error control operator '@' on line 206.
            Open

                public function getValues($recursive = true)
                {
                    $return = [];
                    foreach ($this->_data as $k => $v) {
                        if ($v instanceof self) {
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ErrorControlOperator

            Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

            Example

            function foo($filePath) {
                $file = @fopen($filPath); // hides exceptions
                $key = @$array[$notExistingKey]; // assigns null to $key
            }

            Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

            Missing class import via use statement (line '362', column '22').
            Open

                    $media = new MediaModel();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '816', column '20').
            Open

                    return new Ajde_Model_Validator($this);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '711', column '23').
            Open

                        throw new Ajde_Exception('Constraints on non primary key fields are currently not supported');
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            The method populateMeta has a boolean flag argument $override, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function populateMeta($values = false, $override = true)
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            Missing class import via use statement (line '371', column '21').
            Open

                    $node = new NodeModel();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '398', column '21').
            Open

                    $meta = new MetaModel();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            The method insert has a boolean flag argument $skipBeforeInsert, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function insert($pkValue = null, $skipBeforeInsert = false)
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method populateMeta has a boolean flag argument $values, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function populateMeta($values = false, $override = true)
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            Missing class import via use statement (line '331', column '35').
            Open

                        $metaCollection = new MetaCollection();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '657', column '27').
            Open

                        $parent = new Ajde_Db_Table($parent);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '707', column '23').
            Open

                        throw new Ajde_Exception('Could not load parent model \''.$column."'");
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '886', column '43').
            Open

                        $item->set($updatedField, new Ajde_Db_Function($updatedField));
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '864', column '36').
            Open

                    $collection->addFilter(new Ajde_Filter_Where($parentField, Ajde_Filter::FILTER_IS, null));
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '780', column '27').
            Open

                            throw new Ajde_Exception(sprintf('beforeValidate() must return either TRUE or FALSE'));
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '896', column '38').
            Open

                        $children->addFilter(new Ajde_Filter_Where($parentField, Ajde_Filter::FILTER_EQUALS, $item->getPK()));
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '695', column '23').
            Open

                        throw new Ajde_Exception('Model '.(string) $this->getTable().' not loaded when loading parent');
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            The method getDisplayField uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        return current($this->getTable()->getFieldNames());
                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method loadByFields uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $values[] = $value;
                        }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method getValues uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                @$return[$k] = (string) $v;
                            }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class 'Ajde_Component_String' in method 'isEncrypted'.
            Open

                    return substr_count(Ajde_Component_String::decrypt(parent::_get($field)),
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method _load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        if ($populate === true) {
                            $this->reset();
                            $this->loadFromValues($result);
                        }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method getMetaValues uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $meta[$result['meta']] = $result['value'];
                                }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method getMetaValues uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                    } else {
                                        $meta[$result['meta']] = [
                                            $meta[$result['meta']],
                                            $result['value'],
                                        ];
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                    } else {
                                        $values[] = (string) $value;
                                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                if ($this->has($field) && ($this->get($field) === 0 || $this->get($field) === '0')) {
                                    $sqlFields[] = $field;
                                    $sqlValues[] = '?';
                                    $values[] = (string) parent::_get($field);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    parent::_set($field, null);
                                }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method _recurseChildren uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $item->save();
                        }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class 'Ajde_Component_String' in method 'decrypt'.
            Open

                        Ajde_Component_String::decrypt(parent::_get($field)));
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Ajde_Crud_Cms_Meta' in method 'saveMetaValue'.
            Open

                    $metaType = Ajde_Crud_Cms_Meta::fromType($meta->getType());
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                // Field is required but has an empty value..
                                // (shouldn't have passed validation)
                                // TODO: set to empty string or ignore?
                            }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                    } else {
                                        $values[] = (string) $value;
                                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        $this->set($pk, null);
                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            if ($this->has($field) && !$this->isEmpty($field)) {
                                if ($this->get($field) instanceof Ajde_Db_Function) {
                                    $sqlFields[] = $field;
                                    $sqlValues[] = (string) $this->get($field);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method getValues uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $return[$k] = $v;
                        }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $sqlSet[] = $field.' = ?';
                                    $value = parent::_get($field);
                                    if (is_float($value)) {
                                        $values[] = $value;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class 'Ajde_Component_String' in method 'doEncrypt'.
            Open

                    return Ajde_Component_String::encrypt(self::ENCRYPTION_PREFIX.config('security.secret').$string);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $sqlFields[] = $field;
                                    $sqlValues[] = '?';
                                    $value = parent::_get($field);
                                    if (is_float($value)) {
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            TODO found
            Open

                        // TODO:
            Severity: Minor
            Found in lib/Ajde/Model.php by fixme

            TODO found
            Open

                            // TODO:
            Severity: Minor
            Found in lib/Ajde/Model.php by fixme

            TODO found
            Open

                                // TODO: set to empty string or ignore?
            Severity: Minor
            Found in lib/Ajde/Model.php by fixme

            TODO found
            Open

                        // TODO:
            Severity: Minor
            Found in lib/Ajde/Model.php by fixme

            TODO found
            Open

                    // TODO: if last triggered in event cueue, throw exception
            Severity: Minor
            Found in lib/Ajde/Model.php by fixme

            TODO found
            Open

                    // TODO: parse array and typecast to match fields settings
            Severity: Minor
            Found in lib/Ajde/Model.php by fixme

            TODO found
            Open

                        // TODO:
            Severity: Minor
            Found in lib/Ajde/Model.php by fixme

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            foreach ($results as $result) {
                                if (isset($meta[$result['meta']])) {
                                    if (is_array($meta[$result['meta']])) {
                                        $meta[$result['meta']][] = $result['value'];
                                    } else {
            Severity: Major
            Found in lib/Ajde/Model.php and 1 other location - About 2 hrs to fix
            core/modules/node/model/NodeModel.php on lines 865..878

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 121.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            The property $_jsonFields is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            The property $_validators is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            The class Ajde_Model is not named in CamelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCaseClassName

            Since: 0.2

            It is considered best practice to use the CamelCase notation to name classes.

            Example

            class class_name {
            }

            Source

            The property $_hasMeta is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            The property $_displayField is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            The property $_metaLookup is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            The property $_table is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            The property $_encrypedFields is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            Avoid variables with short names like $pk. Configured minimum length is 3.
            Open

                    $pk = $this->getTable()->getPK();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $pk. Configured minimum length is 3.
            Open

                    $pk = $this->getTable()->getPK();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            The property $_tableName is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                    $id = $this->getPK();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            The property $_autoloadParents is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            Avoid variables with short names like $pk. Configured minimum length is 3.
            Open

                    $pk = $this->getTable()->getPK();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            The property $_metaValues is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            Avoid variables with short names like $pk. Configured minimum length is 3.
            Open

                    $pk = $this->getTable()->getPK();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            The property $_connection is not named in camelCase.
            Open

            class Ajde_Model extends Ajde_Object_Standard
            {
                const ENCRYPTION_PREFIX = '$$$ENCRYPTED$$$';
            
                protected $_connection;
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCasePropertyName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name attributes.

            Example

            class ClassName {
                protected $property_name;
            }

            Source

            Avoid variables with short names like $pk. Configured minimum length is 3.
            Open

                    $pk = $this->getTable()->getPK();
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $fk. Configured minimum length is 3.
            Open

                    $fk = $this->getTable()->getFK($column);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $fk. Configured minimum length is 3.
            Open

                    $fk = $this->getTable()->getFK($parent);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $fk. Configured minimum length is 3.
            Open

                    $fk = $this->getTable()->getFK($column);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            The method _load is not named in camelCase.
            Open

                protected function _load($sql, $values, $populate = true)
                {
                    $statement = $this->getConnection()->prepare($sql);
                    $statement->execute($values);
                    $result = $statement->fetch(PDO::FETCH_ASSOC);
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCaseMethodName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name methods.

            Example

            class ClassName {
                public function get_name() {
                }
            }

            Source

            The method _set is not named in camelCase.
            Open

                protected function _set($name, $value)
                {
                    parent::_set($name, $value);
                    if ($this->isFieldEncrypted($name)) {
                        parent::_set($name, $this->encrypt($name));
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCaseMethodName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name methods.

            Example

            class ClassName {
                public function get_name() {
                }
            }

            Source

            The method _get is not named in camelCase.
            Open

                protected function _get($name)
                {
                    if ($this->isFieldEncrypted($name)) {
                        return $this->decrypt($name);
                    }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCaseMethodName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name methods.

            Example

            class ClassName {
                public function get_name() {
                }
            }

            Source

            The method _getValidator is not named in camelCase.
            Open

                private function _getValidator()
                {
                    return new Ajde_Model_Validator($this);
                }
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCaseMethodName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name methods.

            Example

            class ClassName {
                public function get_name() {
                }
            }

            Source

            The method _recurseChildren is not named in camelCase.
            Open

                private function _recurseChildren(
                    $collection,
                    $collectionName,
                    $parentField,
                    $levelField,
            Severity: Minor
            Found in lib/Ajde/Model.php by phpmd

            CamelCaseMethodName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name methods.

            Example

            class ClassName {
                public function get_name() {
                }
            }

            Source

            There are no issues that match your filters.

            Category
            Status