Function validate
has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring. Open
public function validate($options = [])
{
$fieldsArray = $this->_model->getTable()->getFieldProperties();
$fieldOptions = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function validate($options = [])
{
$fieldsArray = $this->_model->getTable()->getFieldProperties();
$fieldOptions = [];
Function _initValidators
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
private function _initValidators($fieldOptions)
{
foreach ($fieldOptions as $fieldName => $fieldProperties) {
switch (issetor($fieldProperties['type'])) {
case Ajde_Db::FIELD_TYPE_DATE:
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _initValidators
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function _initValidators($fieldOptions)
{
foreach ($fieldOptions as $fieldName => $fieldProperties) {
switch (issetor($fieldProperties['type'])) {
case Ajde_Db::FIELD_TYPE_DATE:
Function shouldValidateDynamicField
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function shouldValidateDynamicField($fieldOptions)
{
if (isset($fieldOptions['showOnlyWhen'])) {
$showOnlyWhens = $fieldOptions['showOnlyWhen'];
foreach ($showOnlyWhens as $fieldName => $showWhenValues) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method _initValidators() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
private function _initValidators($fieldOptions)
{
foreach ($fieldOptions as $fieldName => $fieldProperties) {
switch (issetor($fieldProperties['type'])) {
case Ajde_Db::FIELD_TYPE_DATE:
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method validate() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
public function validate($options = [])
{
$fieldsArray = $this->_model->getTable()->getFieldProperties();
$fieldOptions = [];
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '45', column '61'). Open
$this->_model->addValidator($fieldName, new Ajde_Model_Validator_Unique());
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '28', column '65'). Open
$this->_model->addValidator($fieldName, new Ajde_Model_Validator_Text());
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '41', column '61'). Open
$this->_model->addValidator($fieldName, new Ajde_Model_Validator_Required());
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '31', column '65'). Open
$this->_model->addValidator($fieldName, new Ajde_Model_Validator_Enum());
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '34', column '65'). Open
$this->_model->addValidator($fieldName, new Ajde_Model_Validator_Spatial());
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '21', column '65'). Open
$this->_model->addValidator($fieldName, new Ajde_Model_Validator_Date());
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '25', column '65'). Open
$this->_model->addValidator($fieldName, new Ajde_Model_Validator_Numeric());
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method validate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$value = (string) $value;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The property $_errors is not named in camelCase. Open
class Ajde_Model_Validator extends Ajde_Object_Standard
{
/**
* @var Ajde_Model
*/
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The class Ajde_Model_Validator is not named in CamelCase. Open
class Ajde_Model_Validator extends Ajde_Object_Standard
{
/**
* @var Ajde_Model
*/
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
The property $_model is not named in camelCase. Open
class Ajde_Model_Validator extends Ajde_Object_Standard
{
/**
* @var Ajde_Model
*/
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The method _initValidators is not named in camelCase. Open
private function _initValidators($fieldOptions)
{
foreach ($fieldOptions as $fieldName => $fieldProperties) {
switch (issetor($fieldProperties['type'])) {
case Ajde_Db::FIELD_TYPE_DATE:
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}