lib/Ajde/Object/Standard.php
Missing class import via use statement (line '29', column '23'). Open
Open
throw new Ajde_Exception('Static method Ajde_Object_Standard::create() only available in PHP >= 5.3.0');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method create uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
// TODO:
throw new Ajde_Exception('Static method Ajde_Object_Standard::create() only available in PHP >= 5.3.0');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
TODO found Open
Open
// TODO:
- Exclude checks
The class Ajde_Object_Standard is not named in CamelCase. Open
Open
abstract class Ajde_Object_Standard extends Ajde_Object_Magic
{
protected static $__pattern = self::OBJECT_PATTERN_STANDARD;
public static function __getPattern()
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
The property $__pattern is not named in camelCase. Open
Open
abstract class Ajde_Object_Standard extends Ajde_Object_Magic
{
protected static $__pattern = self::OBJECT_PATTERN_STANDARD;
public static function __getPattern()
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The method __getPattern is not named in camelCase. Open
Open
public static function __getPattern()
{
return self::$__pattern;
}
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}