Sign upLogin

nabble/ajde

View on GitHub
Star
lib/Ajde/Resource/Image/Gravatar.php

Summary

Maintainability
A
45 mins
Test Coverage

Method get has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static function get($email, $s = 80, $d = 'mm', $r = 'g', $img = false, $atts = [])
Severity: Minor
Found in lib/Ajde/Resource/Image/Gravatar.php - About 45 mins to fix

    The method get has a boolean flag argument $img, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public static function get($email, $s = 80, $d = 'mm', $r = 'g', $img = false, $atts = [])
    Severity: Minor
    Found in lib/Ajde/Resource/Image/Gravatar.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The class Ajde_Resource_Image_Gravatar is not named in CamelCase.
    Open

    class Ajde_Resource_Image_Gravatar
{
    /**
     * Get either a Gravatar URL or complete image tag for a specified email address.
     *
    Severity: Minor
    Found in lib/Ajde/Resource/Image/Gravatar.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Avoid variables with short names like $s. Configured minimum length is 3.
    Open

        public static function get($email, $s = 80, $d = 'mm', $r = 'g', $img = false, $atts = [])
    Severity: Minor
    Found in lib/Ajde/Resource/Image/Gravatar.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $r. Configured minimum length is 3.
    Open

        public static function get($email, $s = 80, $d = 'mm', $r = 'g', $img = false, $atts = [])
    Severity: Minor
    Found in lib/Ajde/Resource/Image/Gravatar.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $d. Configured minimum length is 3.
    Open

        public static function get($email, $s = 80, $d = 'mm', $r = 'g', $img = false, $atts = [])
    Severity: Minor
    Found in lib/Ajde/Resource/Image/Gravatar.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status