Sign upLogin

nabble/ajde

View on GitHub
Star
lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php

Summary

Maintainability
A
35 mins
Test Coverage

Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(Google_Client $client)
    {
        if (!function_exists('memcache_connect') && !class_exists('Memcached')) {
            throw new Google_Cache_Exception('Memcache functions not available');
        }
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method get has a boolean flag argument $expiration, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function get($key, $expiration = false)
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '41', column '23').
Open

            throw new Google_Cache_Exception('Memcache functions not available');
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '45', column '29').
Open

            $this->mc = new Memcached();
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '51', column '27').
Open

                throw new Google_Cache_Exception('You need to supply a valid memcache host and port');
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '139', column '23').
Open

            throw new Google_Cache_Exception("Couldn't connect to memcache server");
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '101', column '23').
Open

            throw new Google_Cache_Exception("Couldn't store data in cache");
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '131', column '29').
Open

            $this->mc = new Memcached();
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method get uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $ret = memcache_get($this->connection, $key);
        }
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method set uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $rc = memcache_set($this->connection, $key, $data, false);
        }
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method connect uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->connection = memcache_pconnect($this->host, $this->port);
        }
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            memcache_delete($this->connection, $key, 0);
        }
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->host = $client->getClassConfig($this, 'host');
            $this->port = $client->getClassConfig($this, 'port');
            if (empty($this->host) || empty($this->port)) {
                throw new Google_Cache_Exception('You need to supply a valid memcache host and port');
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The class Google_Cache_Memcache is not named in CamelCase.
Open

class Google_Cache_Memcache extends Google_Cache_Abstract
{
    private $connection = false;
    private $mc = false;
    private $host;
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Avoid variables with short names like $mc. Configured minimum length is 3.
Open

    private $mc = false;
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $rc. Configured minimum length is 3.
Open

        $rc = false;
Severity: Minor
Found in lib/Ajde/Social/Provider/Google/Google/Cache/Memcache.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status