Avoid using static access to class 'Ajde_Event' in method 'addTimeoutWarning'. Open
Ajde_Event::register('Ajde_Layout', 'beforeGetContents', 'requireTimeoutWarning');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'UserModel' in method 'getLoggedInUser'. Open
$this->_user = UserModel::getLoggedIn();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method beforeInvoke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
Ajde::app()->getRequest()->set('message', trans('Please log on to view this page'));
Ajde::app()->getResponse()->dieOnCode(Ajde_Http_Response::RESPONSE_TYPE_UNAUTHORIZED);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
TODO found Open
// TODO: possible undesired behaviour when called by Ajde_Acl_Controller,- Exclude checks
The property $_allowedActions is not named in camelCase. Open
abstract class Ajde_User_Controller extends Ajde_Controller
{
protected $_user = null;
protected $_allowedActions = [- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The class Ajde_User_Controller is not named in CamelCase. Open
abstract class Ajde_User_Controller extends Ajde_Controller
{
protected $_user = null;
protected $_allowedActions = [- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
The property $_user is not named in camelCase. Open
abstract class Ajde_User_Controller extends Ajde_Controller
{
protected $_user = null;
protected $_allowedActions = [- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $_logonRoute is not named in camelCase. Open
abstract class Ajde_User_Controller extends Ajde_Controller
{
protected $_user = null;
protected $_allowedActions = [- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}