Sign upLogin

nabeelamjad/poke-api

View on GitHub
Star
lib/poke-api/signature.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method add_optional_signature_information has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def self.add_optional_signature_information(sig, api_client)
        %i(android_gps_info sensor_info device_info activity_status location_fix).each do |i|
          name = Helpers.camel_case_lower(i)

          if api_client.send(i)
Severity: Minor
Found in lib/poke-api/signature.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Redundant use of Object#to_s in interpolation.
Open

            i == :location_fix ? (sig.send(i) << message) : sig.send("#{i.to_s}=", message)
Severity: Minor
Found in lib/poke-api/signature.rb by rubocop

This cop checks for string conversion in string interpolation, which is redundant.

Example:

# bad

"result is #{something.to_s}"

Example:

# good

"result is #{something}"

There are no issues that match your filters.

Category
Status