Sign upLogin

nadar/quill-delta-parser

View on GitHub
Star

Showing 14 of 14 total issues

Line has 34 functions (exceeds 20 allowed). Consider refactoring.
Open

class Line
{
    /**
     * @var integer The status of a line which is not picked or done, which is default.
     */
Severity: Minor
Found in src/Line.php - About 4 hrs to fix

    Function render has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public function render(Lexer $lexer)
    {
        $isOpen = false;
        $isEmpty = false;
        $listTag = null;
    Severity: Minor
    Found in src/listener/Lists.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method render has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function render(Lexer $lexer)
    {
        $isOpen = false;
        $isEmpty = false;
        $listTag = null;
    Severity: Major
    Found in src/listener/Lists.php - About 2 hrs to fix

      Function render has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function render(Lexer $lexer)
    {
        $isOpen = false;
        foreach ($this->picks() as $pick) {
            if (!$pick->line->isDone() && !$pick->line->hasAttributes() && !$pick->line->isInline()) {
      Severity: Minor
      Found in src/listener/Text.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

                      if ($isOpen && ($next && !$next->isInline())) {
                    $isOpen = $this->output($output, self::CLOSEP, false);

                // if its open and we dont have a next element, its the end of the document! lets close this damn paragraph.
                } elseif ($isOpen && !$next) {
      Severity: Critical
      Found in src/listener/Text.php - About 2 hrs to fix

        Function opsToLines has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function opsToLines(array $ops)
    {
        $lines = [];
        $i = 0;
        foreach ($ops as $delta) {
        Severity: Minor
        Found in src/Lexer.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function render(Lexer $lexer)
    {
        $isOpen = false;
        foreach ($this->picks() as $pick) {
            if (!$pick->line->isDone() && !$pick->line->hasAttributes() && !$pick->line->isInline()) {
        Severity: Minor
        Found in src/listener/Text.php - About 1 hr to fix

          Method opsToLines has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function opsToLines(array $ops)
    {
        $lines = [];
        $i = 0;
        foreach ($ops as $delta) {
          Severity: Minor
          Found in src/Lexer.php - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php

namespace nadar\quill\listener;

use nadar\quill\InlineListener;
            Severity: Minor
            Found in src/listener/BackgroundColor.php and 1 other location - About 55 mins to fix
            src/listener/Color.php on lines 1..31

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php

namespace nadar\quill\listener;

use nadar\quill\InlineListener;
            Severity: Minor
            Found in src/listener/Color.php and 1 other location - About 55 mins to fix
            src/listener/BackgroundColor.php on lines 1..31

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function __construct($index, $input, array $attributes, Lexer $lexer, $hadEndNewline, $hasNewline)
            Severity: Minor
            Found in src/Line.php - About 45 mins to fix

              Function process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function process(Line $line)
    {
        $link = $line->getAttribute('link');
        if ($link) {
            $wrapper = '';
              Severity: Minor
              Found in src/listener/Link.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function while has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function while(callable $condition)
    {
        $iterate = true;
        $i = $this->getIndex();
        while ($iterate) {
              Severity: Minor
              Found in src/Line.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function renderTable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function renderTable(array $rows, array $head = [])
    {
        $buffer = '<table class="table table-bordered table-striped table-hover table-sm small" border="1" width="100%" cellpadding="3" cellspacing="0">';

        if (!empty($head)) {
              Severity: Minor
              Found in src/Debug.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language