Sign upLogin

nadoka/nadoka

View on GitHub
Star
ndk/client.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method login has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def login
      pass = nil
      nick = nil
      @username = nil
Severity: Minor
Found in ndk/client.rb - About 1 hr to fix

    Method start has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def start
      send_thread = Thread.new{
        begin
          while q = @queue.pop
            begin
    Severity: Minor
    Found in ndk/client.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def start
      send_thread = Thread.new{
        begin
          while q = @queue.pop
            begin
    Severity: Minor
    Found in ndk/client.rb - About 1 hr to fix

      Method login has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def login
      pass = nil
      nick = nil
      @username = nil
      Severity: Minor
      Found in ndk/client.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method recv_from_client has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def recv_from_client
      while !@sock.closed?
        begin
          str = @sock.gets
          if str
      Severity: Minor
      Found in ndk/client.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method send_from_client has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def send_from_client msg, from
      until @manager.connected
        # ignore
        return
      end
      Severity: Minor
      Found in ndk/client.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method nadoka_client_command has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def nadoka_client_command cmd, args
      cmd ||= ''
      case cmd.upcase
      when 'QUIT'
        @manager.invoke_event :quit_program
      Severity: Minor
      Found in ndk/client.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status