nadoka/nadoka

View on GitHub
ndk/server_state.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class NDK_State has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class NDK_State
    class ChannelState
      def initialize name
        @name  = name
        @topic = nil
Severity: Minor
Found in ndk/server_state.rb - About 2 hrs to fix

    Method on_353 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def on_353 rch, users
          ch = canonical_channel_name(rch)
    
          if @current_channels.has_key? ch
            chs = @current_channels[ch]
    Severity: Minor
    Found in ndk/server_state.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method on_mode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def on_mode nick, args
            while mode = args.shift
              modes = mode.split(//)
              flag  = modes.shift
              modes.each{|m|
    Severity: Minor
    Found in ndk/server_state.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status