Sign upLogin

naffiq/yii2-kkb

View on GitHub
Star

Showing 3 of 3 total issues

Method processRequest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function processRequest($orderId, $amount, $currencyCode = 398, $b64 = true)
    {
        if (is_numeric($orderId)) {
            if ($orderId > 0) {
                $orderId = sprintf("%06d", $orderId);
Severity: Minor
Found in KKBPayment.php - About 1 hr to fix

    Function processRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function processRequest($orderId, $amount, $currencyCode = 398, $b64 = true)
    {
        if (is_numeric($orderId)) {
            if ($orderId > 0) {
                $orderId = sprintf("%06d", $orderId);
    Severity: Minor
    Found in KKBPayment.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function checkErrors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function checkErrors($error)
    {
        if ($error !== false) {
            if (strpos($error, "error:0906D06C") > 0) {
                throw new CertificateException("Error reading Certificate. Verify Cert type.", 1);
    Severity: Minor
    Found in KKBSign.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language