nafigator/Veles

Avoid classes with short names like Db. Configured minimum length is 3.

Open

class Db extends DbTransactionHandler
{
    /**
     * Получение значения столбца таблицы
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Fo {

}

interface Fo {

}

Method run has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function run($type, $message, $file, $line, $defined)

Missing class import via use statement (line '47', column '14').

Open

            throw new \Exception('Not valid token value');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method query has a boolean flag argument $pager, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function query($sql, $pager = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '42', column '13').

Open

        throw new \RuntimeException('Unknown data type');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method addConnection has a boolean flag argument $default, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function addConnection(DbConnection $conn, $default = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method getAll has a boolean flag argument $filter, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function getAll($filter = false, $pager = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '174', column '15').

Open

                throw new \Exception('Not found model id!');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method getAll has a boolean flag argument $pager, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function getAll($filter = false, $pager = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method __construct has a boolean flag argument $case_sensitive, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function __construct($case_sensitive = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method find has a boolean flag argument $filter, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function find($filter = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '64', column '21').

Open

        $real_mime = (new \finfo(FILEINFO_MIME))

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '86', column '14').

Open

            throw new \InvalidArgumentException($msg);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method __construct has a boolean flag argument $case_sensitive, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function __construct($case_sensitive = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method delete has a boolean flag argument $ids, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function delete($ids = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid assigning values to variables in if clauses and the like (line '49', column '18').

Open

    public function detach(SplObserver $observer)
    {
        if (false !== ($key = array_search($observer, $this->observers, true))) {
            unset($this->observers[$key]);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid unused parameters such as '$tpl'.

Open

    public function isCached($tpl)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid assigning values to variables in if clauses and the like (line '49', column '7').

Open

    public function run(): void
    {
        $route      = $this->getRoute();
        $controller = $route->getController();
        $action     = $route->getActionName();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '49', column '7').

Open

    public function run(): void
    {
        $route      = $this->getRoute();
        $controller = $route->getController();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid unused parameters such as '$path'.

Open

    public function get($path)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}