Sign upLogin

naomichi-y/ecs_deployer

View on GitHub
Star

Showing 6 of 6 total issues

Method decrypt_environment_variables! has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def decrypt_environment_variables!(task_definition)
        raise TaskDefinitionValidateError, '\'container_definition\' is undefined.' unless task_definition.key?(:container_definitions)

        task_definition[:container_definitions].each do |container_definition|
          next unless container_definition.key?(:environment)
Severity: Minor
Found in lib/ecs_deployer/task/client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wait_for_deploy has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def wait_for_deploy(service, task_definition_arn)
        raise ServiceNotFoundError, "'#{service}' service is not found." unless exist?(service)

        wait_time = 0
        @logger.info 'Start deployment.'
Severity: Minor
Found in lib/ecs_deployer/service/client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wait_for_deploy has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def wait_for_deploy(service, task_definition_arn)
        raise ServiceNotFoundError, "'#{service}' service is not found." unless exist?(service)

        wait_time = 0
        @logger.info 'Start deployment.'
Severity: Minor
Found in lib/ecs_deployer/service/client.rb - About 1 hr to fix

    Method deploy_status has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def deploy_status(service, task_definition_arn)
        detect_stopped_task(service, task_definition_arn)

        # Get current tasks
        result = @ecs.list_tasks(
    Severity: Minor
    Found in lib/ecs_deployer/service/client.rb - About 1 hr to fix

      Method deploy_status has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def deploy_status(service, task_definition_arn)
        detect_stopped_task(service, task_definition_arn)

        # Get current tasks
        result = @ecs.list_tasks(
      Severity: Minor
      Found in lib/ecs_deployer/service/client.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exist? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def exist?(service)
        status = nil
        result = @ecs.describe_services(
          cluster: @cluster,
          services: [service]
      Severity: Minor
      Found in lib/ecs_deployer/service/client.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language