naoufal/react-native-touch-id

View on GitHub
android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method authenticate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @TargetApi(Build.VERSION_CODES.M)
    @ReactMethod
    public void authenticate(final String reason, final ReadableMap authConfig, final Callback reactErrorCallback, final Callback reactSuccessCallback) {
        final Activity activity = getCurrentActivity();
        if (inProgress || !isAppActive || activity == null) {
Severity: Minor
Found in android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java - About 1 hr to fix

    Method isFingerprintAuthAvailable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private int isFingerprintAuthAvailable() {
            if (android.os.Build.VERSION.SDK_INT < 23) {
                return FingerprintAuthConstants.NOT_SUPPORTED;
            }
    
    
    Severity: Minor
    Found in android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return FingerprintAuthConstants.NOT_ENROLLED;
    Severity: Major
    Found in android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return FingerprintAuthConstants.IS_SUPPORTED;
      Severity: Major
      Found in android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status