Sign upLogin

nathan-v/aws_okta_keyman

View on GitHub
Star
aws_okta_keyman/duo.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function get_status has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def get_status(self, transaction_id, sid):
        """Get Duo auth status

        Args:
            transaction_id: String Duo transaction ID
Severity: Minor
Found in aws_okta_keyman/duo.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function do_auth has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def do_auth(self, sid, certs_url):
        """Handle initial auth with Duo

        Args:
            sid: String Duo session ID if we have it
Severity: Minor
Found in aws_okta_keyman/duo.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function trigger_duo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def trigger_duo(self, passcode=""):
        """Try to get a Duo Push without needing an iframe

        Args:
            passcode: String passcode to pass along to the OTP factor
Severity: Minor
Found in aws_okta_keyman/duo.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (80 > 79 characters)
Open

        params = ("sid={}&device=phone1&" "factor={}&out_of_date=False").format(
Severity: Minor
Found in aws_okta_keyman/duo.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status