Sign upLogin

nathanhammond/ember-a11y

View on GitHub
Star

Showing 4 of 4 total issues

Function registerKeywords has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function registerKeywords() {
  registerKeyword('get-outlet-state', {
    willRender(renderNode, env) {
      let focusingOutlet = env.view;
      focusingOutlet.send('checkFocus', env.outletState);
Severity: Minor
Found in addon/ember-internals.js - About 1 hr to fix

    Function registerKeywords has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    export function registerKeywords() {
  registerKeyword('get-outlet-state', {
    willRender(renderNode, env) {
      let focusingOutlet = env.view;
      focusingOutlet.send('checkFocus', env.outletState);
    Severity: Minor
    Found in addon/ember-internals.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function render has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        render(renderNode, env, scope, params, hash, template, inverse, visitor) {
    Severity: Major
    Found in addon/ember-internals.js - About 1 hr to fix

      Function pivotRouteIdentifier has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function pivotRouteIdentifier(oldHandlers, newHandlers) {
  if (oldHandlers === undefined) {
    return newHandlers[0];
  }
      Severity: Minor
      Found in addon/utils/pivot-route-identifier.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language