Sign upLogin

natydev/fitbark

View on GitHub
Star
lib/fitbark/handler/v2/set_daily_goal.rb

Summary

Maintainability
A
0 mins
Test Coverage

Fitbark::Handler::V2::SetDailyGoal#validate_input calls 'opts[:set_on]' 2 times
Open

          unless opts[:set_on].instance_of?(Date)
            raise Fitbark::Errors::FormatError
              .new(message: "Wrong or missing date for param 'set_on'")
          end
          if opts[:set_on] < Date.today
Severity: Minor
Found in lib/fitbark/handler/v2/set_daily_goal.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Fitbark::Handler::V2::SetDailyGoal#build_params doesn't depend on instance state (maybe move it to another class?)
Open

        def build_params(goal_points, set_on)
Severity: Minor
Found in lib/fitbark/handler/v2/set_daily_goal.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

Fitbark::Handler::V2 has the name 'V2'
Open

    module V2
Severity: Minor
Found in lib/fitbark/handler/v2/set_daily_goal.rb by reek

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

unexpected token tCOLON (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

            "daily_goal": goal_points.to_s,
Severity: Minor
Found in lib/fitbark/handler/v2/set_daily_goal.rb by rubocop

unexpected token $end (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

Severity: Minor
Found in lib/fitbark/handler/v2/set_daily_goal.rb by rubocop

unexpected token tCOLON (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

            "date": set_on.to_s
Severity: Minor
Found in lib/fitbark/handler/v2/set_daily_goal.rb by rubocop

unexpected token tRCURLY (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

          }
Severity: Minor
Found in lib/fitbark/handler/v2/set_daily_goal.rb by rubocop

There are no issues that match your filters.

Category
Status