ncbo/bioportal_web_ui

View on GitHub

Showing 628 of 628 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

lunr.SortedSet.prototype.forEach = function (fn, ctx) {
  return this.elements.forEach(fn, ctx)
}
Severity: Major
Found in public/browse/lib/lunr.js/lunr.js and 5 other locations - About 35 mins to fix
public/browse/lib/lunr.js/lib/index.js on lines 50..52
public/browse/lib/lunr.js/lib/sorted_set.js on lines 72..74
public/browse/lib/lunr.js/lib/sorted_set.js on lines 87..89
public/browse/lib/lunr.js/lunr.js on lines 614..616
public/browse/lib/lunr.js/lunr.js on lines 830..832

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

lunr.SortedSet.prototype.map = function (fn, ctx) {
  return this.elements.map(fn, ctx)
}
Severity: Major
Found in public/browse/lib/lunr.js/lib/sorted_set.js and 5 other locations - About 35 mins to fix
public/browse/lib/lunr.js/lib/index.js on lines 50..52
public/browse/lib/lunr.js/lib/sorted_set.js on lines 87..89
public/browse/lib/lunr.js/lunr.js on lines 614..616
public/browse/lib/lunr.js/lunr.js on lines 629..631
public/browse/lib/lunr.js/lunr.js on lines 830..832

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

lunr.SortedSet.prototype.forEach = function (fn, ctx) {
  return this.elements.forEach(fn, ctx)
}
Severity: Major
Found in public/browse/lib/lunr.js/lib/sorted_set.js and 5 other locations - About 35 mins to fix
public/browse/lib/lunr.js/lib/index.js on lines 50..52
public/browse/lib/lunr.js/lib/sorted_set.js on lines 72..74
public/browse/lib/lunr.js/lunr.js on lines 614..616
public/browse/lib/lunr.js/lunr.js on lines 629..631
public/browse/lib/lunr.js/lunr.js on lines 830..832

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

lunr.Index.prototype.off = function (name, fn) {
  return this.eventEmitter.removeListener(name, fn)
}
Severity: Major
Found in public/browse/lib/lunr.js/lunr.js and 5 other locations - About 35 mins to fix
public/browse/lib/lunr.js/lib/index.js on lines 50..52
public/browse/lib/lunr.js/lib/sorted_set.js on lines 72..74
public/browse/lib/lunr.js/lib/sorted_set.js on lines 87..89
public/browse/lib/lunr.js/lunr.js on lines 614..616
public/browse/lib/lunr.js/lunr.js on lines 629..631

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        addClass: function(element, className, animationCompleted, options) {
          options = options || {};
          return animateAfter('addClass', element, suffixClasses(className, '-add'), animationCompleted, options.to);
        },
Severity: Minor
Found in public/browse/lib/angular-animate/angular-animate.js and 1 other location - About 35 mins to fix
public/browse/lib/angular-animate/angular-animate.js on lines 2116..2119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var ajax_process_ont_init = function() {
  ajax_ont_array = jQuery("a.ont4ajax").toArray();
  ajax_process_ont_interval = window.setInterval(ajax_process_ont, ajax_process_timing);
};
Severity: Minor
Found in app/assets/javascripts/bp_ajax_controller.js and 1 other location - About 35 mins to fix
app/assets/javascripts/bp_ajax_controller.js on lines 114..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var ajax_process_cls_init = function() {
  ajax_cls_array = jQuery("a.cls4ajax").toArray();
  ajax_process_cls_interval = window.setInterval(ajax_process_cls, ajax_process_timing);
};
Severity: Minor
Found in app/assets/javascripts/bp_ajax_controller.js and 1 other location - About 35 mins to fix
app/assets/javascripts/bp_ajax_controller.js on lines 45..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        removeClass: function(element, className, animationCompleted, options) {
          options = options || {};
          return animateAfter('removeClass', element, suffixClasses(className, '-remove'), animationCompleted, options.to);
        }
Severity: Minor
Found in public/browse/lib/angular-animate/angular-animate.js and 1 other location - About 35 mins to fix
public/browse/lib/angular-animate/angular-animate.js on lines 2111..2114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return true;
Severity: Major
Found in public/browse/lib/angular-mocks/angular-mocks.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return false;
    Severity: Major
    Found in public/widgets/jquery.ncbo.autocomplete.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return data == d;
      Severity: Major
      Found in public/browse/lib/angular-mocks/angular-mocks.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if (pivotElem === elem) return pivot
        Severity: Major
        Found in public/browse/lib/lunr.js/lib/sorted_set.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            if (pivotElem === elem) return pivot
          Severity: Major
          Found in public/browse/lib/lunr.js/lunr.js - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return
            Severity: Major
            Found in app/controllers/ontologies_controller.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return
              Severity: Major
              Found in app/controllers/ontologies_controller.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return
                Severity: Major
                Found in app/controllers/ontologies_controller.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return
                  Severity: Major
                  Found in app/controllers/ontologies_controller.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return
                    Severity: Major
                    Found in app/controllers/ontologies_controller.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return
                      Severity: Major
                      Found in app/controllers/ontologies_controller.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return
                        Severity: Major
                        Found in app/controllers/ontologies_controller.rb - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language