Sign upLogin

ndlib/sipity

View on GitHub
Star
app/conversions/sipity/conversions/convert_to_year.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method convert_to_year has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def convert_to_year(input)
        return input if input.is_a?(Integer)
        return input.to_year if input.respond_to?(:to_year)
        return input.year if input.respond_to?(:year)
        return convert_to_year(input.to_date) if input.respond_to?(:to_date)
Severity: Minor
Found in app/conversions/sipity/conversions/convert_to_year.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return input.to_i.zero? ? nil : input.to_i if input.respond_to?(:to_i)
Severity: Major
Found in app/conversions/sipity/conversions/convert_to_year.rb - About 30 mins to fix

There are no issues that match your filters.

Category
Status