Sign upLogin

neka-nat/tensorboard-chainer

View on GitHub
Star
tb_chainer/graph.py

Summary

Maintainability
D
1 day
Test Coverage

Function build_computational_graph has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

def build_computational_graph(
        outputs, remove_split=True, variable_style='default',
        function_style='default', rankdir='TB', remove_variable=False,
        show_name=True):
    """Builds a graph of functions and variables backward-reachable from outputs.
Severity: Minor
Found in tb_chainer/graph.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function make_list_of_nodes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def make_list_of_nodes(fn):
    list_of_nodes = []
    g = build_computational_graph(fn)
    node_name = NodeName(g.nodes)
    for n in g.nodes:
Severity: Minor
Found in tb_chainer/graph.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function base_name has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def base_name(obj):
        name_scope = (obj.name_scope + '/') if hasattr(obj, 'name_scope') else ''
        if hasattr(obj, '_variable') and obj._variable is not None:
            if isinstance(obj._variable(), chainer.Parameter):
                return name_scope + (('Parameter_' + obj.name) if obj.name is not None else 'Parameter')
Severity: Minor
Found in tb_chainer/graph.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_computational_graph has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def build_computational_graph(
Severity: Major
Found in tb_chainer/graph.py - About 50 mins to fix

    Function convert_dtype has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def convert_dtype(dtype):
    if dtype == np.float32:
        return dt.DT_FLOAT
    elif dtype == np.float64:
        return dt.DT_DOUBLE
    Severity: Minor
    Found in tb_chainer/graph.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return dt.DT_STRING
    Severity: Major
    Found in tb_chainer/graph.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return dt.DT_INT8
      Severity: Major
      Found in tb_chainer/graph.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return dt.DT_INT16
        Severity: Major
        Found in tb_chainer/graph.py - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      for input_ in cand.inputs:
                if input_ is not cand and (input_, cand) not in seen_edges:
                    add_cand(input_)
                    seen_edges.add((input_, cand))
                    nodes.add(input_)
          Severity: Major
          Found in tb_chainer/graph.py and 1 other location - About 2 hrs to fix
          tb_chainer/graph.py on lines 111..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if creator is not None and (creator, cand) not in seen_edges:
                add_cand(creator)
                seen_edges.add((creator, cand))
                nodes.add(creator)
                nodes.add(cand)
          Severity: Major
          Found in tb_chainer/graph.py and 1 other location - About 2 hrs to fix
          tb_chainer/graph.py on lines 117..122

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status