Sign upLogin

nelsonic/arana

View on GitHub
Star

Showing 18 of 18 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function add_milestones(data, callback){
  // console.log('ISSUES URL: '+ data.url)
  data = url_transform(data); // url of the repo
  // console.log('URL transformed to:' + data.url);
  var record = {
Severity: Major
Found in lib/recorder.js and 1 other location - About 1 day to fix
lib/recorder.js on lines 183..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 206.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function add_labels(data, callback){
  // console.log('ISSUES URL: '+ data.url)
  data = url_transform(data); // url of the repo
  // console.log('URL transformed to:' + data.url);
  var record = {
Severity: Major
Found in lib/recorder.js and 1 other location - About 1 day to fix
lib/recorder.js on lines 214..239

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 206.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function tasker has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

 module.exports = function tasker (data) {
   if(!data.url) { // short circuit if no url is set
     return [];
   }
   var uri = URL.parse(data.url);
Severity: Major
Found in lib/tasker.js - About 2 hrs to fix

    Function tasker has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

     module.exports = function tasker (data) {
   if(!data.url) { // short circuit if no url is set
     return [];
   }
   var uri = URL.parse(data.url);
    Severity: Minor
    Found in lib/tasker.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

       if(data.url.match(/following/) && data.entries.length > 0){
     data.entries.forEach(function(e){
       tasks.push('/'+e);
     })
   }
    Severity: Major
    Found in lib/tasker.js and 1 other location - About 2 hrs to fix
    lib/tasker.js on lines 32..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

       if(data.url.match(/followers/) && data.entries.length > 0){
     data.entries.forEach(function(e){
       tasks.push('/'+e);
     })
   }
    Severity: Major
    Found in lib/tasker.js and 1 other location - About 2 hrs to fix
    lib/tasker.js on lines 25..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function add_people has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function add_people(data, method, callback) {
  data = url_transform(data, method);
  var record = {
    id:    aguid(data.url),
    index: 'github',
    Severity: Minor
    Found in lib/recorder.js - About 1 hr to fix

      Function add_issues has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function add_issues(data, callback){
  // console.log('ISSUES URL: '+ data.url)
  data = url_transform(data); // url of the repo
  console.log('add_issues URL transformed to: ' + data.url + " > "+aguid(data.url));
  var record = {
      Severity: Minor
      Found in lib/recorder.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              data.entries.map(function(repo) { // add the follower
        if(existing_repos.indexOf(repo.name) === -1){
          res._source.repos.push(repo);
        }
      });
        Severity: Major
        Found in lib/recorder.js and 1 other location - About 1 hr to fix
        lib/recorder.js on lines 146..150

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              data.entries.map(function(issue) { // add the follower
        if(existing_issues.indexOf(issue.url) === -1){
          res._source.issues.push(issue);
        }
      });
        Severity: Major
        Found in lib/recorder.js and 1 other location - About 1 hr to fix
        lib/recorder.js on lines 95..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function add_repos has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function add_repos(data, callback){
  data = url_transform(data);
  var record = {
    id:    aguid(data.url),
    url:   data.url,
        Severity: Minor
        Found in lib/recorder.js - About 1 hr to fix

          Function save_record_to_elasticsearch has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function save_record_to_elasticsearch (data, callback) {
  // console.log(" - - - - - - - - - - - - - - - URL:")
  // console.log(data.url);
  // if the page scraped was a followers page
          Severity: Minor
          Found in lib/recorder.js - About 1 hr to fix

            Function run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function run (callback) {
  // fetch the next task from the work queue
  wq.next(function(err, task) {
    // console.log(task);
    gs(task.split(' ')[0], function(gserr, data){
            Severity: Minor
            Found in lib/worker.js - About 1 hr to fix

              Function save_record_to_elasticsearch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function save_record_to_elasticsearch (data, callback) {
  // console.log(" - - - - - - - - - - - - - - - URL:")
  // console.log(data.url);
  // if the page scraped was a followers page
              Severity: Minor
              Found in lib/recorder.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function url_transform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function url_transform(data, method) {
  // console.log("Transforming >> " +data.url)
  var uri = url.parse(data.url);
  if(uri.path.match(/tab=repositories/)) { // personal repositories
    var username = uri.path.replace('?tab=repositories','');
              Severity: Minor
              Found in lib/url_transform.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                  return add_issues(data, callback);
              Severity: Major
              Found in lib/recorder.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return add_labels(data, callback);
                Severity: Major
                Found in lib/recorder.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return add_milestones(data, callback);
                  Severity: Major
                  Found in lib/recorder.js - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language