nemesiscodex/openfonacide

View on GitHub

Showing 970 of 970 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if bar_id:
            query_ubicacion += ' AND '
            query_ubicacion += ' ' + tabla_prioridad + '.codigo_barrio_localidad = \'' + bar_id + '\' '
Severity: Major
Found in openfonacide/resumen.py and 1 other location - About 1 hr to fix
openfonacide/resumen.py on lines 426..428

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function makeDataMappingMethods has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function makeDataMappingMethods() {
        // Static variables should be fixed in the scope of the methods.
        var myLogPositive = logPositive;
        var myLogMappingOffset = logMappingOffset;

Severity: Minor
Found in static/js/dncp/util/smartLogSteps.js - About 1 hr to fix

    Function _withPreprocess2 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _withPreprocess2 : function (axis, out, funcWithAxis, funcFlatten) {
            var source = this._array;
            if (!this._size) {
                return;
            }
    Severity: Minor
    Found in static/js/dncp/util/ndarray.js - About 1 hr to fix

      Function sector has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function sector(zr, oldShape, newShape, duration, easing) {
              if (!oldShape) {        // add
                  if (newShape._animationAdd != 'r') {
                      oldShape = {
                          style : {
      Severity: Minor
      Found in static/js/dncp/util/ecAnimation.js - About 1 hr to fix

        Function settings has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                  settings: function(animation, duration, onComplete) {
                    // single settings object
                    if(typeof animation == 'object') {
                      return $.extend(true, {}, $.fn.transition.settings, animation);
                    }
        Severity: Minor
        Found in static/components/transition.js - About 1 hr to fix

          Function field has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                    field: function(field) {
                      var
                        $field      = module.get.field(field.identifier),
                        fieldValid  = true,
                        fieldErrors = []
          Severity: Minor
          Found in static/components/form.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    albers.origin = function (x) {
                        if (!arguments.length) {
                            return origin;
                        }
                        origin = [+x[0], +x[1]];
            Severity: Major
            Found in static/js/dncp/util/projection/albers.js and 1 other location - About 1 hr to fix
            static/js/dncp/util/projection/albers.js on lines 67..73

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              className         : {
                active    : 'active',
                animating : 'animating',
                dimmed    : 'dimmed',
                ios       : 'ios',
            Severity: Major
            Found in static/components/sidebar.js and 1 other location - About 1 hr to fix
            static/js/grid.locale-es.js on lines 108..120

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        masks : {
                            ISO8601Long:"Y-m-d H:i:s",
                            ISO8601Short:"Y-m-d",
                            ShortDate: "n/j/Y",
                            LongDate: "l, F d, Y",
            Severity: Major
            Found in static/js/grid.locale-es.js and 1 other location - About 1 hr to fix
            static/components/sidebar.js on lines 1044..1056

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    albers.parallels = function (x) {
                        if (!arguments.length) {
                            return parallels;
                        }
                        parallels = [+x[0], +x[1]];
            Severity: Major
            Found in static/js/dncp/util/projection/albers.js and 1 other location - About 1 hr to fix
            static/js/dncp/util/projection/albers.js on lines 59..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function min has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                min : kwargs((function () {
                    function withAxis(data, source, offsetStride, axisSize, stride) {
                        var cursor = 0;
                        for (var offset = 0; offset < this._size; offset+=offsetStride) {
                            for (var i = 0; i < stride; i++) {
            Severity: Minor
            Found in static/js/dncp/util/ndarray.js - About 1 hr to fix

              Function buildPath has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      buildPath : function (ctx, style) {
                          var lineType = style.lineType || 'solid';
              
                          ctx.moveTo(style.xStart, style.yStart);
                          if (style.curveness > 0) {
              Severity: Minor
              Found in static/js/dncp/util/shape/MarkLine.js - About 1 hr to fix

                Function max has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    max : kwargs((function () {
                        function withAxis(data, source, offsetStride, axisSize, stride) {
                            var cursor = 0;
                            for (var offset = 0; offset < this._size; offset+=offsetStride) {
                                for (var i = 0; i < stride; i++) {
                Severity: Minor
                Found in static/js/dncp/util/ndarray.js - About 1 hr to fix

                  Function query has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          query: function() {
                            var
                              searchTerm = module.get.value(),
                              cache = module.read.cache(searchTerm)
                            ;
                  Severity: Minor
                  Found in static/components/search.js - About 1 hr to fix

                    Function refresh has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            refresh: function() {
                              if(settings.popup) {
                                $popup = $(settings.popup).eq(0);
                              }
                              else {
                    Severity: Minor
                    Found in static/components/popup.js - About 1 hr to fix

                      Function percent has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                                percent: function(percent) {
                                  percent = (typeof percent == 'string')
                                    ? +(percent.replace('%', ''))
                                    : percent
                                  ;
                      Severity: Minor
                      Found in static/components/progress.js - About 1 hr to fix

                        Function animate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                animate: function(propertyObject, callback) {
                                  module.verbose('Animating box with properties', propertyObject);
                                  callback = callback || function(event) {
                                    module.verbose('Executing animation callback');
                                    if(event !== undefined) {
                        Severity: Minor
                        Found in static/components/shape.js - About 1 hr to fix

                          Function generar_query has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          def generar_query(params):
                              periodo = params.get('anios')
                              ubicaciones = params.get('ubicaciones')
                              prioridades = params.get('prioridades')
                              estados = params.get('estado')
                          Severity: Minor
                          Found in openfonacide/resumen.py - About 1 hr to fix

                            Function reportar has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                            Open

                            def reportar(request):
                                if request.method != 'POST':
                                    return JsonResponse({'error': 'Método inválido.'}, status=405)
                                form = ReporteForm(request.POST)
                                if form.is_valid():
                            Severity: Minor
                            Found in openfonacide/views.py - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function top_establecimientos has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                            Open

                            def top_establecimientos(periodo, prioridades, ubicaciones, ret):
                                query = ('SELECT COUNT(DISTINCT codigo_institucion) AS instituciones_elegibles, '
                                        'codigo_establecimiento FROM ( ')
                                cursor = connection.cursor()
                                union = False
                            Severity: Minor
                            Found in openfonacide/resumen.py - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language